Disable ReflectionAllocationsAnalysis for TypeBasedPointsTo key#367
Open
johannesduesing wants to merge 2 commits into
Open
Disable ReflectionAllocationsAnalysis for TypeBasedPointsTo key#367johannesduesing wants to merge 2 commits into
johannesduesing wants to merge 2 commits into
Conversation
Collaborator
|
Looks good to me. I wonder whether we should rename the ReflectionAllocationsAnalysisScheduler to be compatible with getModuleFQN though. |
Collaborator
Author
|
I think that's fair, i can implement that. However i'm just now wondering: The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #357 the
ReflectionAllocationsAnalysisSchedulershould not be executed with theTypeBasedPointsToCallGraphKey, but it should be run for all other implementations ofPointsToCallGraphKey. This PR proposes one possible solution for the issue - i am however open for discussion, there are many ways this could be realized.This PR moves the
ReflectionAllocationsAnalysisSchedulerinto a separate configuration section, which is not loaded by thePointsToCallGraphKeytrait, but instead by the new and more specifictrait AllocationSiteBasedPointsToCallGraphKey extends PointsToCallGraphKey. TheTypeBasedPointsToCallGraphKeyonly implementsPointsToCallGraphKey, so the incompatible analysis is not loaded. I made all other direct children ofPointsToCallGraphKeyinherit fromAllocationSiteBasedPointsToCallGraphKeyinstead, so they all still load the desired analysis.