-
Notifications
You must be signed in to change notification settings - Fork 6
feat(connections): add Lark CLI direct connection #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
41370e3
Add Lark CLI direct connection
alwaysmavs 05ea678
Hide remote account actions for direct connections
alwaysmavs 2ffbd00
fix(connections): address Lark CLI review feedback
alwaysmavs 11c75e5
fix(connections): harden Lark CLI update verification
alwaysmavs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| import assert from "node:assert/strict" | ||
| import { test } from "vitest" | ||
| import { findOfficialAuthorizationUrl, isVersionNewer, redactCommandError } from "./lark-cli.ts" | ||
|
|
||
| test("Lark CLI update comparison handles stable and prerelease versions", () => { | ||
| assert.equal(isVersionNewer("1.0.82", "1.0.81"), true) | ||
| assert.equal(isVersionNewer("1.1.0", "1.0.99"), true) | ||
| assert.equal(isVersionNewer("1.0.81", "1.0.81"), false) | ||
| assert.equal(isVersionNewer("1.0.81-beta.2", "1.0.81-beta.1"), true) | ||
| assert.equal(isVersionNewer("1.0.81", "1.0.81-beta.2"), true) | ||
| assert.equal(isVersionNewer("invalid", "1.0.81"), false) | ||
| }) | ||
|
|
||
| test("Lark CLI authorization URLs are recovered from JSON without widening the host allowlist", () => { | ||
| assert.equal( | ||
| findOfficialAuthorizationUrl('{"verification_url":"https://open.feishu.cn/device?a=1\\u0026b=2"}'), | ||
| "https://open.feishu.cn/device?a=1&b=2", | ||
| ) | ||
| assert.equal( | ||
| findOfficialAuthorizationUrl("https://open.larksuite.com/device?id=1"), | ||
| "https://open.larksuite.com/device?id=1", | ||
| ) | ||
| assert.equal(findOfficialAuthorizationUrl("https://open.feishu.cn.evil.example/device"), undefined) | ||
| assert.equal(findOfficialAuthorizationUrl("https://open.feishu.cn:8443/device"), undefined) | ||
| }) | ||
|
|
||
| test("Lark CLI command errors redact authorization URLs and credentials", () => { | ||
| const redacted = redactCommandError( | ||
| 'request failed device_code=dev-secret app_secret:app-secret "access_token":"access-secret", refresh_token=refresh-secret https://open.feishu.cn/device?id=secret', | ||
| ) | ||
|
|
||
| assert.match(redacted, /request failed/u) | ||
| assert.equal(redacted.includes("dev-secret"), false) | ||
| assert.equal(redacted.includes("app-secret"), false) | ||
| assert.equal(redacted.includes("access-secret"), false) | ||
| assert.equal(redacted.includes("refresh-secret"), false) | ||
| assert.equal(redacted.includes("id=secret"), false) | ||
| assert.match(redacted, /\[redacted\]/u) | ||
| assert.match(redacted, /\[authorization-url\]/u) | ||
| }) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.