chore: upgrade OpenCode and oo CLI runtimes - #294
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (5)
Summary by CodeRabbit
WalkthroughThe pull request updates OpenCode packages from Possibly related PRs
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches✨ Simplify code
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (2)
electron/agent/agent.test.ts (1)
661-667: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winAssert that the obsolete selector is absent.
The current checks prove that
--teamappears. They also pass if--organizationremains in the embedded source. Add negative assertions forsearch_actions.ts,list_apps.ts, andcall_action.ts.Proposed assertion additions
assert.ok(AGENT_TOOL_FILES["search_actions.ts"]?.includes("--team")) + assert.doesNotMatch(AGENT_TOOL_FILES["search_actions.ts"] ?? "", /--organization/) ... assert.ok(AGENT_TOOL_FILES["list_apps.ts"]?.includes("--team")) + assert.doesNotMatch(AGENT_TOOL_FILES["list_apps.ts"] ?? "", /--organization/) ... assert.ok(AGENT_TOOL_FILES["call_action.ts"]?.includes("--team")) + assert.doesNotMatch(AGENT_TOOL_FILES["call_action.ts"] ?? "", /--organization/)Also applies to: 686-686
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@electron/agent/agent.test.ts` around lines 661 - 667, Extend the embedded-source assertions in the relevant test block to verify the obsolete --organization selector is absent from search_actions.ts, list_apps.ts, and call_action.ts. Keep the existing positive --team assertions and other checks unchanged, using negative assertions against each file’s source content.scripts/open-source-readiness.test.ts (1)
62-67: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick winAssert the runtime SDK pin in the manifest.
@opencode-ai/sdkis a runtime dependency inpackage.json:46and is imported byelectron/agent/sidecar.ts:1. This test checks the two development dependencies, then checks documentation for the SDK. It does not check the manifest's runtime SDK entry. A stale SDK pin could pass this test.Proposed assertion
expect(manifest.devDependencies?.["opencode-ai"]).toBe("1.18.10") expect(manifest.devDependencies?.["`@opencode-ai/plugin`"]).toBe("1.18.10") + expect(manifest.dependencies?.["`@opencode-ai/sdk`"]).toBe("1.18.10")🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@scripts/open-source-readiness.test.ts` around lines 62 - 67, Update the manifest assertions in the open-source readiness test to also verify that the runtime dependency `@opencode-ai/sdk` is pinned to 1.18.10, alongside the existing devDependency checks. Keep the documentation and notices assertions unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/architecture.md`:
- Line 119: Update the architecture documentation’s description of
oo-identity.ts persistence to state that the team name is written to
identity.team. Describe identity.organization only as a legacy migration input,
not as the persisted output.
In `@docs/conventions.md`:
- Line 221: Update the documentation sentence around the `--team` guidance to
scope the selector explicitly to OOMOL commands: require OOMOL calls to pass
`--team`, and state that OpenConnector calls must omit both `--team` and
`--personal`.
In `@docs/openconnector-support-plan.md`:
- Around line 81-82: Update the current implementation-result statement in the
document to report the bundled oo CLI as version 1.7.1, while preserving 1.5.1
references that explicitly describe the pre-upgrade baseline.
---
Nitpick comments:
In `@electron/agent/agent.test.ts`:
- Around line 661-667: Extend the embedded-source assertions in the relevant
test block to verify the obsolete --organization selector is absent from
search_actions.ts, list_apps.ts, and call_action.ts. Keep the existing positive
--team assertions and other checks unchanged, using negative assertions against
each file’s source content.
In `@scripts/open-source-readiness.test.ts`:
- Around line 62-67: Update the manifest assertions in the open-source readiness
test to also verify that the runtime dependency `@opencode-ai/sdk` is pinned to
1.18.10, alongside the existing devDependency checks. Keep the documentation and
notices assertions unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 2767788a-3237-48f0-87e5-128ec88d86f0
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (24)
CONTRIBUTING.mdREADME.es.mdREADME.ja.mdREADME.ko.mdREADME.mdREADME.zh-CN.mdTHIRD_PARTY_NOTICES.mddocs/architecture.mddocs/bug-report-command-optimization.mddocs/conventions.mddocs/key-decisions.mddocs/open-source-readiness-audit.mddocs/openconnector-support-plan.mddocs/project-overview.mdelectron/agent/agent.test.tselectron/agent/manager.test.tselectron/agent/manager.tselectron/agent/oo-identity.test.tselectron/agent/oo-identity.tselectron/agent/tool-sources.test.tselectron/agent/tool-sources.tspackage.jsonscripts/oo-cli.tsscripts/open-source-readiness.test.ts
|
Addressed the remaining CodeRabbit nitpicks in 70dceec: embedded Link-tool tests now assert that |
1 participant
Summary
Upgrade Wanta's bundled agent runtimes to the current verified versions:
--organizationoption to--team.User impact and root cause
oo CLI 1.6.0 renamed the user-facing organization concept to team and removed the old
--organization/--orgcommand options. Wanta still generated the legacy option and persistedidentity.organization, so upgrading the binary alone would make team-scoped connector inventory and action calls fail during argument parsing.The OpenCode runtime was also behind the pinned SDK/runtime version. Keeping the binary, SDK, provider package, documentation, notices, and readiness assertions aligned avoids runtime/protocol drift in packaged and development builds.
Implementation
--team <teamName>for OOMOL connector calls and raw CLI guidance.identity.teamwhile recognizing and migrating an existing legacyidentity.organizationentry without disturbing neighboring TOML settings.@opencode-ai/sdkto 1.18.10 and align the OpenAI provider dependency and documentation.Validation
corepack pnpm run lintcorepack pnpm run ts-checkcorepack pnpm run formatcorepack pnpm test— 283 files, 2,129 tests passedcorepack pnpm run build:appcorepack pnpm run prepare:binaries5e89ed24).oo connector apps --helpexposes--teamand the removed--organizationoption is rejected.