Skip to content

Fix empty sidebar scroll - #290

Merged
alwaysmavs merged 1 commit into
mainfrom
codex/fix-empty-sidebar-scroll
Jul 29, 2026
Merged

Fix empty sidebar scroll#290
alwaysmavs merged 1 commit into
mainfrom
codex/fix-empty-sidebar-scroll

Conversation

@alwaysmavs

Copy link
Copy Markdown
Contributor

Summary

Fix the sidebar showing a vertical scrollbar when the task list is empty.

Problem

With no tasks, the sidebar still displayed a scrollbar even though the empty state visually fit within the available area. This made the empty task panel look slightly overflowed and suggested that hidden content was present.

Root cause

The task section heading was rendered before an empty-state component whose minimum height was set to the full height of the scroll container. The heading height and margin were therefore added on top of a full-height empty state, making the total content slightly taller than the container and triggering vertical overflow.

Fix

The sidebar session scroll container now uses a vertical flex layout. The task and project empty states use min-h-0 with flex-1, so they occupy only the remaining height after section controls and headings. The scroll container keeps overflow-y-auto, preserving normal scrolling when task or project content genuinely exceeds the available space.

Validation

  • corepack pnpm run lint
  • corepack pnpm run ts-check
  • Oxfmt check for the modified files
  • git diff --check
  • Electron development startup

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The sidebar layout styling is updated in three container declarations. The session-scroll container now explicitly uses flex layout, while the SidebarEmptyState and ProjectSidebarEmptyState containers use min-h-0 instead of min-h-full. No component logic, props, or rendering structure changes.

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title is clear but does not follow the required type(scope): subject format. Rename it to match the required format, for example fix(sidebar): remove empty-state scrollbar.
✅ Passed checks (3 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed It covers Summary, Problem, Root cause, Fix, and Validation, but omits the template's Safety and Compatibility checklist.
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch codex/fix-empty-sidebar-scroll

Comment @coderabbitai help to get the list of available commands.

@alwaysmavs
alwaysmavs marked this pull request as ready for review July 29, 2026 11:16
@alwaysmavs
alwaysmavs merged commit 19225ea into main Jul 29, 2026
3 checks passed
@alwaysmavs
alwaysmavs deleted the codex/fix-empty-sidebar-scroll branch July 29, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant