Fix empty sidebar scroll - #290
Merged
Merged
Conversation
WalkthroughThe sidebar layout styling is updated in three container declarations. The session-scroll container now explicitly uses flex layout, while the 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✨ Finishing Touches✨ Simplify code
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the sidebar showing a vertical scrollbar when the task list is empty.
Problem
With no tasks, the sidebar still displayed a scrollbar even though the empty state visually fit within the available area. This made the empty task panel look slightly overflowed and suggested that hidden content was present.
Root cause
The task section heading was rendered before an empty-state component whose minimum height was set to the full height of the scroll container. The heading height and margin were therefore added on top of a full-height empty state, making the total content slightly taller than the container and triggering vertical overflow.
Fix
The sidebar session scroll container now uses a vertical flex layout. The task and project empty states use
min-h-0withflex-1, so they occupy only the remaining height after section controls and headings. The scroll container keepsoverflow-y-auto, preserving normal scrolling when task or project content genuinely exceeds the available space.Validation
corepack pnpm run lintcorepack pnpm run ts-checkgit diff --check