Repository navigation
drm/msm/dp: port AUX ownership and display state machine from 7.2 research - #85
Merged
Merged
Conversation
Owner
Author
|
config_ctrl LSCLK dead-store fixed (from the dp-cluster port review, evidence/dp-cluster-port-review.md §1): the |
1 of 3 tasks
…earch Port the DP cluster rework from the 7.2 overlay (507356d) to the current 7.3 tree: explicit AUX transfer ownership with fault draining, state-lock-serialized ctrl transitions, audio restart/stop entrypoints, and the rewritten dp_display host lifecycle. Adaptations for the 7.3 base: - config_ctrl keeps the RMW clear of stream-specific fields from the #73 stream split (commit 7de83c2), layered under the overlay rework. - bridge ops switch from .atomic_reset to .atomic_create_state (base commit 65dc3b4 removed atomic_reset support). - container_of and long-line wraps to keep checkpatch line-length clean. Build-verified on the Surface Pro 11 (native arm64 gcc 15.2, shipped 7.3.0-jg-1sp11v4 source + Ubuntu config): all eight dp/*.o plus the full msm/ directory compile with zero warnings or errors. Signed-off-by: Leon Silcott <lnsilcott@gmail.com>
The 2 << LSCLK_DIV_SHIFT default written before the read-modify-write was a dead store: the RMW immediately overwrote it, so the link-level divider field kept whatever the register held instead of the intended 1/4 LCLK default. Move the default assignment after the RMW so the divider is explicitly re-set on every configure, matching the intent of the split in 7de83c2 (found in the dp-cluster port review). Built on Surface Pro 11 (arm64 gcc 15.2, 7.3.0-jg-1sp11v4 headers), zero warnings. Signed-off-by: Leon Silcott <lnsilcott@gmail.com>
ooaklee
force-pushed
the
x/dp-aux-owner-cluster
branch
from
November 14, 2026 05:55
cf18939 to
0ee2338
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the DP cluster rework from the 7.2 overlay (
507356d03f3c) to the current 7.3 tree:dp_aux.c/h): explicit owner model with fault draining,owner_stoppinggating, and PHY-calibration-on-error handlingdp_ctrl.c/h): state-lock-serialized resource transitions,phy_init/exitwithnewly_ownedsemantics, ownership/error query API (has_phy_refs,has_power_ref,link_regs_accessible,record_aux_fault)dp_display.c): rewritten host state machine with admit/recover paths, locked IRQ handling, and bounded HPD/attention processingdp_audio.c/h):msm_dp_audio_stop/restartentrypoints; ALSA intent survives video modesetsAdaptations for the 7.3 base (re-derived, not copied)
config_ctrlkeeps the RMW clear of stream-specific bits from the media: port OV13858 and VD55G0 research with explicit stop retries (draft) #73 stream split (7de83c21291f) layered under the overlay rework..atomic_reset→.atomic_create_state(base65dc3b473bb5cremovedatomic_resetsupport).Build verification
On the Surface Pro 11 (native arm64 gcc 15.2, shipped 7.3.0-jg-1sp11v4 source + Ubuntu config): all 8 dp/*.o + full drivers/gpu/drm/msm/ compile with 0 warnings, 0 errors.
Test plan
Stacked context: base already carries #81/#82 merges. This PR is the dp cluster prerequisite for reopening the #72 family follow-ups.