Repository navigation
clk: qcom / usb: typec: propagate reset errors and retry PS883x recovery - #79
Merged
ooaklee merged 3 commits intoNov 12, 2026
Merged
Conversation
Return assert, update, readback and deassert errors to reset consumers. Do not issue deassert or the pulse delay after a failed assert. Split and ported from frozen Type-C recovery source overlay 507356d (PR #72), based on 7.3.y source c8cdaac. Only this file is carried here; the broader DP/PMIC/QMP recovery overlay is deferred. Original overlay authorship retained; no submitter certification or hardware qualification is asserted.
Only commit the cached orientation after its hardware update succeeds, track whether the register orientation is valid across resets and retries, and use the idempotent reset helper for probe unwind and remove. Preserve the current platform USB4 fallback policy unchanged. Split and ported from frozen Type-C recovery source overlay 507356d (PR #72), based on 7.3.y source c8cdaac. Only this file is carried here; the broader DP/PMIC/QMP recovery overlay is deferred. Original overlay authorship retained; no submitter certification or hardware qualification is asserted.
ooaklee
marked this pull request as ready for review
November 12, 2026 03:20
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qualcomm reset requests can currently report success after the assert, deassert or completion read fails. PS883x can cache an orientation before a failed register write, causing an identical retry to be skipped; probe/remove can also release regulator enables already released by reset.
This splits two bounded fixes from #72 onto
sp11/ubuntu-qcom-x1e-7.3.y:Validation on the exact head:
drivers/clk/qcom/reset.oanddrivers/usb/typec/mux/ps883x.o,W=1, GCC 15.2 / GNU ld 2.46: passed without warnings.714bf34d0b3f; GitHubtypec-boundedregression CI passed on that head.The original author commits are retained. The other twelve files of #72 remain in that draft with their broader PMIC/DP/AUX/audio/QMP lifecycle work. These results cover source behavior and compilation; physical hotplug, suspend/recovery and kernel packaging remain separate qualification steps.