Repository navigation
Conversation
Device-tree systems can use platform-profile providers even when ACPI is disabled, but the framework currently declines to register its class in that case. Register the class unconditionally and create the legacy ACPI attribute group only after ACPI has initialized successfully. Record that group registration and use it to guard legacy notifications and teardown. This keeps the class path independent of ACPI while also avoiding a stale acpi_kobj after an ACPI initialization failure. This exposes the native /sys/class/platform-profile/ interface without creating a synthetic /sys/firmware/acpi hierarchy. Existing ACPI systems retain the legacy aggregate attributes unchanged. This is a contained rework of the original SP11 non-ACPI enablement. Link: 106ad0d Signed-off-by: Leon Silcott <leon@boasi.io> (cherry picked from commit ab12a0a)
The Surface Pro 11 has active cooling and supports SAM performance profiles, but its registry group does not instantiate the existing platform-profile and fan-speed devices. Add the existing fan-capable profile node and fan-speed node only to the Denali software-node group. Other Surface device groups are unchanged. Link: 5c513ff Signed-off-by: Leon Silcott <leon@boasi.io> (cherry picked from commit 6680508)
The Surface Pro 11 needs a lower CPU-frequency ceiling in its low-power profile to match the validated cool-running baseline. Describe the 2.515 GHz ceiling and default low-power selection on an SP11-only software node. Set up frequency-QoS only when that per-device property is present. Devices without it retain the legacy TMP-then-fan write order, including writes that repeat the current profile. Track cpufreq policies through CREATE and REMOVE notifications plus a per-device CPU-hotplug state, so a policy that is fully offline at probe is capped when a CPU returns. Hold policy references while attaching requests, clear stored raw pointers synchronously on REMOVE, and stop hotplug callbacks before tearing down requests and the notifier. When entering low power, apply the cap before fan and TMP changes; when leaving, restore fan and TMP before dropping the cap. If a SAM write fails, read TMP back and reconcile fan and cap conservatively. An unavailable cpufreq subsystem degrades to profile-only operation. Omit the staging implementation’s no-op power-supply notifier. This is a contained rework of the original SP11 low-power implementation. Link: 30972bd Signed-off-by: Leon Silcott <leon@boasi.io> (cherry picked from commit a89959a)
This was referenced Sep 30, 2026
Owner
Author
|
Closed as an inactive/consolidated review vehicle during the 20 October kernel queue cleanup—not merged, newly hardware-qualified or accepted for upstream by this closure. Previously recorded v8 acceptance evidence stands unchanged; this closure only retires the review vehicle. The original source head and contributor history remain retained. Where a closed topic branch is removed, its verified The separate tested-source staging route and all outstanding upstream reconstruction, provenance, fork-CI and deviation/promotion gates are tracked in OE #33. Experimental reverse-engineering PRs remain separate and unmerged. Beta/default branches and installed kernels are unchanged. Retained exact source: af4d11ea94712abad563b8381ba7b05ae1937d1e. |
7 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current October 4 checkpoint
The exact combined v8 trial is documented in the
qualification report and combined PR #68.
Its ordinary-use report is joined by a bounded three-cycle camera/reopen/
indicator check in Power Saver with simultaneous quiet playback. This is
combined-candidate evidence, not a standalone installation or hardware
qualification of this topic head. Source, dependency base and draft state stay
unchanged. Earlier preparation text below is historical; old 7.2.2 review/test
vehicles are now closed as superseded, with history/evidence retained.
Earlier source/review checkpoint
Held 7.2.5 topic — do not merge
Review the three profile/fan/CPU-policy ports at
af4d11ea94712abad563b8381ba7b05ae1937d1eagainst their immediate batterydependency,
x/sp11-battery-7.2.5-20260928(53905a94e735). No audio or cameradependency is added. Historical review #38 remains unchanged and held.
Scope and provenance
Preserve the platform-profile class interface without ACPI, SP11 profile/fan
registry nodes and guarded low-power CPU policy. Two registry commits require
documented context adaptations because this dependency base already omits the
SAM battery/AC nodes: those providers stay absent while the intended SP11
profile/fan nodes remain. The resulting registry blob matches the previously
reviewed battery/profile composition, rather than silently restoring providers.
Original author/date/message and cherry-pick source trailers remain intact.
The two registry context resolutions are explicit; no contributor sign-off or
hardware equivalence is inferred from patch preservation.
Evidence and open gates
W=1Image/modules/DTBs build of this unchanged head.CONFIG_CPU_FREQ=ncompile control.The beta-only workflow does not run automatically for this stacked draft.
Neither the disabled-CPU-frequency control nor a complete build proves safe
runtime policy. Keep v23 as the qualified recovery reference.
The eventual target is
sp11/ubuntu-qcom-x1e-7.2.y-betaafter refresh and batteryqualification. Do not merge into the battery staging branch. Prepare/revalidate
the final exact beta-relative composition; retain all behavior/deviation holds.
Combined v8 source and ordinary use evidence
An October 3 source-closure audit maps all 3 commits in this focused
series to combined qualification PR #68, head
8ba2b75713feb5c72bbc11dd8cce4048e23cdeea, ABI7.2.5-jg-0sp11v8-qcom-x1e.Author identity/date, subject, message text and stable patch identity match;
actual replay trailers are checked in either recorded direction and through
intermediate qualification replays.
Every composed final file entry matches its owning topic's blob, mode and type.
Across all six held groups, the complete refresh-to-v8 tree delta is the 36
owned file entries and the qualification changelog. Six additional commits
touch only that changelog; no unattributed source change was found. This is traceability to the trial, not a fresh standalone
build or installation of this PR, or proof of every integration-to-port behavior.
Power profiles are human-reported working in the combined checklist. The read-only snapshot confirms the native platform-profile provider and three profile choices. The running v8 ABI was independently read back. Authorized root
readback verifies the installed v8 image/configuration/boot DTBs, current
initramfs against the installation receipt, and owned v8/v23 boot entries;
v23 remains the default/fallback. No userspace or boot configuration was changed
for that readback.
Profile/CPU-cap/fan transitions, hotplug/error/teardown and other-machine/power-state qualification remain open. Presence of working choices is not coverage of every policy lifecycle.
This advances bounded combined ordinary-use evidence only. Existing deeper
checks, documented-deviation/contributor/complete-CI-policy acceptance and exact
final-composition gates remain open. Do not test the known deep-resume failure
without a separate supervised plan. Source heads, dependency bases and draft
status remain unchanged; do not merge into staging or infer beta integration.
OpenCode Zai-Codex reviews are advisory, not human contributor or maintainer tags.
October 4 native Power Saver observation
The existing native provider stays low-power throughout all 150 coordinated
camera/playback samples, with each of three CPU-policy maxima at 2,188,800 kHz.
Preview and sound remain stable. This is current-state/coexistence evidence,
not a new transition, fan, CPU-policy hotplug, service-restart or fault test.
The existing power-profiles service was not replaced; catalogue authority and
the final component-pairing policy stay separate in
Lexr #45.