Repository navigation
Conversation
Qualcomm battmgr is the authoritative battery provider on the Surface Pro 11. Do not instantiate the primary Surface Aggregator Module battery device in the Denali-specific software-node group, avoiding a duplicate battery provider without adding a machine quirk to the shared driver. Keep the separate SAM AC-adapter node registered. This extracts and narrows the Denali battery fix from the original combined touchscreen and battery commit. Link: 3fc7c52 Signed-off-by: Justin White <kyjus25@gmail.com> Signed-off-by: Leon Silcott <leon@boasi.io> (cherry picked from commit 9074c73)
The X1E Qualcomm battery manager registers qcom-battmgr-ac as the authoritative mains supply. Retaining the Surface Aggregator ADP1 node creates a second mains interface for the same Denali power source. Follow the upstream Surface Laptop 7 precedent and omit the SAM AC node from the Denali-only registry group. Keep this correction separate from the Justin White battery-node extraction so its original authorship and sign-off remain intact. Link: torvalds@0488073 Signed-off-by: Leon Silcott <leon@boasi.io> (cherry picked from commit 4eadf8d)
|
Closed as an inactive/consolidated review vehicle during the 20 October kernel queue cleanup—not merged, newly hardware-qualified or accepted for upstream by this closure. Previously recorded v8 acceptance evidence stands unchanged; this closure only retires the review vehicle. The original source head and contributor history remain retained. Where a closed topic branch is removed, its verified The separate tested-source staging route and all outstanding upstream reconstruction, provenance, fork-CI and deviation/promotion gates are tracked in OE #33. Experimental reverse-engineering PRs remain separate and unmerged. Beta/default branches and installed kernels are unchanged. Retained exact source: 53905a94e7352c3ba02af044e4cdba0eae79c4b9. |
Current October 4 checkpoint
The exact combined v8 trial is documented in the
qualification report and combined PR #68.
Its ordinary-use report is joined by a bounded three-cycle camera/reopen/
indicator check in Power Saver with simultaneous quiet playback. This is
combined-candidate evidence, not a standalone installation or hardware
qualification of this topic head. Source, dependency base and draft state stay
unchanged. Earlier preparation text below is historical; old 7.2.2 review/test
vehicles are now closed as superseded, with history/evidence retained.
Earlier source/review checkpoint
Held 7.2.5 topic — do not merge
Review the two battery/AC-provider ports at
53905a94e7352c3ba02af044e4cdba0eae79c4b9against the refresh branch in #51(
bdae86ee3b4e). Platform-profile work depends on this registry composition;it is not included here, nor is any audio or camera work.
Historical review: #37. Its older reviewed 7.2.2 head remains unchanged and held.
Scope and provenance
Omit the Denali SAM battery and AC registry nodes to preserve the intended
provider arrangement without duplicating the upstream battery-manager path.
The delta is two node removals in
surface_aggregator_registry.c, not a newbattery driver or evidence that upstream provider behavior has been qualified.
Retain Justin White's and Leon Silcott's original contributions, author dates,
messages and cherry-pick source trailers. No attribution or sign-off is invented.
This preserves the existing guarded topic, not hardware equivalence to v23.
Evidence and open gates
W=1Image/modules/DTBs build of this unchanged head.The beta-only workflow does not run automatically for this stacked draft.
Build/registry checks are not battery hardware acceptance. Keep v23 as the
qualified recovery reference.
The eventual target is
sp11/ubuntu-qcom-x1e-7.2.y-beta; the current base is fordependency review only. Do not merge into staging. Qualify #51 and this topic,
then prepare/revalidate the exact beta-relative composition before proceeding
with the separately held platform-profile topic.
Combined v8 source and ordinary use evidence
An October 3 source-closure audit maps all 2 commits in this focused
series to combined qualification PR #68, head
8ba2b75713feb5c72bbc11dd8cce4048e23cdeea, ABI7.2.5-jg-0sp11v8-qcom-x1e.Author identity/date, subject, message text and stable patch identity match;
actual replay trailers are checked in either recorded direction and through
intermediate qualification replays.
The dependent composition owns 1 overlapping file; TX/Golden clock/audio and battery/profile registry composition are checked at their final owners. Every composed final file entry matches its owning topic's blob, mode and type.
Across all six held groups, the complete refresh-to-v8 tree delta is the 36
owned file entries and the qualification changelog. Six additional commits
touch only that changelog; no unattributed source change was found. This is traceability to the trial, not a fresh standalone
build or installation of this PR, or proof of every integration-to-port behavior.
Battery/charger indication is human-reported working in the combined checklist. The running v8 ABI was independently read back. Authorized root
readback verifies the installed v8 image/configuration/boot DTBs, current
initramfs against the installation receipt, and owned v8/v23 boot entries;
v23 remains the default/fallback. No userspace or boot configuration was changed
for that readback.
Measured below-full discharge/recharge energy phases, effective-provider/lifetime/supplier links, repeatability and other-device/power-state qualification remain open. Indicator behavior is not measured battery endurance.
This advances bounded combined ordinary-use evidence only. Existing deeper
checks, documented-deviation/contributor/complete-CI-policy acceptance and exact
final-composition gates remain open. Do not test the known deep-resume failure
without a separate supervised plan. Source heads, dependency bases and draft
status remain unchanged; do not merge into staging or infer beta integration.
OpenCode Zai-Codex reviews are advisory, not human contributor or maintainer tags.
October 4 charging observation
The tester reports charging from 9% to 97%. A ten-minute near-full observation
contains 61 Charging/USB-online samples at 44.342 Wh out of 44.79 Wh. Energy
was unchanged in that window; this supports state/reporting, not measured net
charging, discharge, taper or endurance. No settings were changed. Full
provider/supplier/error/teardown qualification remains separate.