Skip to content

[QUALIFICATION - DO NOT MERGE] SP11 v8 GPI ordering test #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ooaklee wants to merge 2 commits into from
Closed

[QUALIFICATION - DO NOT MERGE] SP11 v8 GPI ordering test #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f35a9f8
dmaengine: qcom: gpi: order event ring pointer reads
ooaklee Sep 3, 2026
e805a56
UBUNTU: [Packaging] use SP11 v8 touch qualification ABI
ooaklee Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions debian.qcom-x1e/changelog
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
linux-qcom-x1e (7.2.2-jg-0sp11v8) resolute; urgency=medium

* Test ordered GPI event-ring pointer reads on SP11 touch and pen.

-- Leon Silcott <leon@boasi.io> Thu, 03 Sep 2026 09:53:40 +0100

linux-qcom-x1e (7.2.2-jg-0) resolute; urgency=medium

* arm64: dts: qcom: x1-lenovo-ideacentre-mini-01q8x10: discriminate compatible strings
Expand Down
12 changes: 9 additions & 3 deletions drivers/dma/qcom/gpi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,8 +662,14 @@ static inline u32 gpi_read_reg(struct gpii *gpii, void __iomem *addr)

static phys_addr_t gpi_read_ev_rp(struct gpii *gpii)
{
u32 lsb = gpi_read_reg(gpii, gpii->ev_ring_rp_lsb_reg);
u32 msb;
u32 lsb, msb;

/*
* The event read pointer publishes entries written by the device into
* coherent memory. Use ordered MMIO reads so those writes are visible
* before the caller consumes an event from the ring.
*/
lsb = readl(gpii->ev_ring_rp_lsb_reg);

/*
* Denali publishes and may inspect the event ring before either QSPI
Expand All @@ -674,7 +680,7 @@ static phys_addr_t gpi_read_ev_rp(struct gpii *gpii)
if (!gpii_has_denali_qspi(gpii))
return lsb;

msb = gpi_read_reg(gpii, gpii->ev_ring_rp_lsb_reg + 4);
msb = readl(gpii->ev_ring_rp_lsb_reg + 4);

return ((phys_addr_t)msb << 32) | lsb;
}
Expand Down
Loading