perf: read file content directly into the result buffer - #166
Open
benjaminbruun wants to merge 1 commit into
Open
perf: read file content directly into the result buffer#166benjaminbruun wants to merge 1 commit into
benjaminbruun wants to merge 1 commit into
Conversation
Member
Author
|
For nrf-softsim |
benjaminbruun
force-pushed
the
perf/read-file-single-alloc
branch
2 times, most recently
from
August 27, 2026 13:08
714c5d8 to
ce8c061
Compare
benjaminbruun
marked this pull request as ready for review
August 27, 2026 13:08
ss_storage_read_file bounced every read through a temporary heap copy; reading into the ss_buf halves the transient allocation per read. Adds host coverage for the compact read path, which no test compiled before. Signed-off-by: Benjamin Bruun <bb@onomondo.com>
benjaminbruun
enabled auto-merge (squash)
September 1, 2026 14:03
benjaminbruun
force-pushed
the
perf/read-file-single-alloc
branch
from
September 1, 2026 14:03
ce8c061 to
5d36eaf
Compare
benjaminbruun
disabled auto-merge
September 2, 2026 10:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ss_storage_read_filein the compact storage backend read every file into a temporarybuffer and then copied it into the returned
ss_buf, so each read transiently held twoheap copies of the content. It now reads directly into the result buffer; error paths
still zeroize before freeing. Adds
tests/storage_compact, the first host coverage ofthe compact read path (whole read, offset window, past-EOF and missing-file cases).