adding meeting notes from previous meeting and rng proprosal in an ma…#157
adding meeting notes from previous meeting and rng proprosal in an ma…#157bparbhu wants to merge 4 commits into
Conversation
…rkdown format to share
Craigacp
left a comment
Craigacp
left a comment
There was a problem hiding this comment.
LGTM aside from the things I commented on.
|
|
||
| ### Type Constraints | ||
|
|
||
| `T` in (`tensor(bfloat16)`, `tensor(double)`, `tensor(float)`, `tensor(float16)`): |
There was a problem hiding this comment.
We need RandomUniform to range over all tensor types so we can make it generate bits.
There was a problem hiding this comment.
Understood, I'll make the corrections. Apologies for the late reply to this.
There was a problem hiding this comment.
Made the change please take a look
|
|
||
| **T2** in (`tensor(bfloat16)`, `tensor(double)`, `tensor(float)`, `tensor(float16)`): | ||
|
|
||
| Constrain output types to float tensors. |
There was a problem hiding this comment.
Output types can be any tensor type.
There was a problem hiding this comment.
Understood, I'll make the change.
There was a problem hiding this comment.
Made the change please take a look
| The discussion covered plans for integrating the Threefry implementation into the ONNX codebase and broader repository organization practices. Adam discussed determining the appropriate location for new implementation code, while both participants exchanged experiences managing work across personal and organizational GitHub repositories. | ||
|
|
||
| ### Intellectual Property and Open Source | ||
| Adam and Brian discussed intellectual property considerations surrounding open-source contributions, including Oracle's internal policies and the advantages of contributing through organization-owned repositories. They also reflected on sustainability challenges facing open-source projects and the impact of cloud vendors on project funding and governance. |
There was a problem hiding this comment.
s/Oracle's internal policies/Oracle's open source policies/
There was a problem hiding this comment.
Ah sorry about that I will omit this section.
There was a problem hiding this comment.
It's fine to stay in, we definitely discussed it and the way that Oracle contributes to open source projects is public (and similar to most large corporations). Just needs to be specific about what policy.
There was a problem hiding this comment.
Made the change please take a look at let me know what you think.
2 participants
…rkdown format to share