[RFC]Implement reifyResultShapes for Sub, Mul, and Div ops - #3561
Open
kimm240 wants to merge 2 commits into
Open
[RFC]Implement reifyResultShapes for Sub, Mul, and Div ops#3561kimm240 wants to merge 2 commits into
kimm240 wants to merge 2 commits into
Conversation
Signed-off-by: Hyun Gyu Kim <kimm240@telepix.net>
Collaborator
|
Can one of the admins verify this patch? |
Signed-off-by: Hyun Gyu Kim <kimm240@telepix.net>
Collaborator
|
Can one of the admins verify this patch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reifyResultShapesforonnx.Sub,onnx.Mul, andonnx.Divusing the same broadcast shape logic asonnx.Add(PR [RFC]Introduce Reify IndexExpr Value Provider for ONNX #3520 /ReifyIndexExprValueProvider).reifyBroadcastResultShapesand refactorONNXAddOpto use it.OpsWithReifyResultShapesand regenerateONNXOps.td.inc.onnx_reify_result_shapes.mlirand add Sub/Mul/Div test cases.Test
onnx_reify_result_shapes_add.mlir.onnx_reify_result_shapes.mliras a single lit test file covering Add, Sub, Mul, and Div.