fix: v1.2.0 pre-release review findings - #20
Merged
Conversation
MAJOR 1: chrome_trace no longer claims clang -ftime-trace as its own input — usage prompt + reader docstring now redirect to clang-time-trace ([total] tagging) and cmake-profile (B/E folding), so agents aren't steered around the honesty features those backends exist for. MINOR 2: criterion drops the name-based report/ guard — it had zero true positives (bookkeeping dirs never contain new/estimates.json) and silently suppressed a genuinely-written bench named "report"; test rewritten to assert the honest behavior. MINOR 3: a tag_override that collides across cats keeps the cat tag too, preserving the unit-name uniqueness invariant. MINOR 4: a valid trace with zero digestible X events now errors loudly; a B/E-only trace gets an explicit cmake-profile redirect instead of a silent empty report. MINOR 5: gh auth probe memoized per process (300s TTL, testing hook) — platform_capabilities no longer pays a network round-trip per call. NITs: negative B/E fold durations dropped (clock corruption, not data); numstat rename-ambiguity documented; gha expand truncation markers; usage-convention header covers all four feedback channels; directory-ref cache path applies the same mutation-proof freeze as the cached path; README lists ninja's format alias. Reviewer's re-verify probes re-run live: convention redirect, clang [total] intact (44/60 units), B/E loud redirect, cmake folding intact, 7-tool surface, wheel content clean. 206 tests pass. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies all 11 findings from the Fable-max pre-release review (verdict: FIX-THEN-RELEASE, 0 blockers). Headline: chrome_trace's steering text no longer routes -ftime-trace users around clang_time_trace's [total] honesty tagging; criterion no longer fabricates absence for a bench named "report"; B/E-only traces fail loud with a cmake-profile redirect; gh auth probe memoized. Reviewer's three re-verify steps re-run live, all green; 206 tests.
🤖 Generated with Claude Code