Skip to content

Upgrade flow-core-contracts to v1.10.4 - #8632

Open
janezpodhostnik wants to merge 1 commit into
masterfrom
janez/upgrade-core-contracts-v1.10.4
Open

Upgrade flow-core-contracts to v1.10.4#8632
janezpodhostnik wants to merge 1 commit into
masterfrom
janez/upgrade-core-contracts-v1.10.4

Conversation

@janezpodhostnik

@janezpodhostnik janezpodhostnik commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Upgrade flow-core-contracts/lib/go/contracts and templates from v1.10.3 to v1.10.4 in all three modules (root, insecure, integration).

v1.10.4 exposes FlowFees fee receiver addresses via a getter and moves child fee account creation into the FlowFees contract (onflow/flow-core-contracts#615, onflow/flow-core-contracts#617).

Changes

  • Bump flow-core-contracts dependencies to v1.10.4
  • Update hardcoded genesis state commitments for all chains
  • Update bootstrap test state commitments
  • Bump the minimum storage value in Test_ExecutionMatchesVerification to account for the FlowFees account's increased storage usage

Related: onflow/flow-core-contracts#615


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Summary by CodeRabbit

  • Bug Fixes

    • Updated storage-limit validation scenarios to reflect current reservation requirements.
    • Corrected expected genesis and bootstrap state commitments across supported chain configurations.
  • Maintenance

    • Updated contract-related components to the latest compatible release.
    • Refreshed integration and test expectations to keep validation aligned with current network behavior.

@janezpodhostnik
janezpodhostnik requested a review from a team as a code owner July 31, 2026 13:28
@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 6 package(s) with unknown licenses.
See the Details below.

License Issues

go.mod

PackageVersionLicenseIssue Type
github.com/onflow/flow-core-contracts/lib/go/contracts1.10.4NullUnknown License
github.com/onflow/flow-core-contracts/lib/go/templates1.10.4NullUnknown License

insecure/go.mod

PackageVersionLicenseIssue Type
github.com/onflow/flow-core-contracts/lib/go/contracts1.10.4NullUnknown License
github.com/onflow/flow-core-contracts/lib/go/templates1.10.4NullUnknown License

integration/go.mod

PackageVersionLicenseIssue Type
github.com/onflow/flow-core-contracts/lib/go/contracts1.10.4NullUnknown License
github.com/onflow/flow-core-contracts/lib/go/templates1.10.4NullUnknown License

OpenSSF Scorecard

PackageVersionScoreDetails
gomod/github.com/onflow/flow-core-contracts/lib/go/contracts 1.10.4 UnknownUnknown
gomod/github.com/onflow/flow-core-contracts/lib/go/templates 1.10.4 UnknownUnknown
gomod/github.com/onflow/flow-core-contracts/lib/go/contracts 1.10.4 UnknownUnknown
gomod/github.com/onflow/flow-core-contracts/lib/go/templates 1.10.4 UnknownUnknown
gomod/github.com/onflow/flow-core-contracts/lib/go/contracts 1.10.4 UnknownUnknown
gomod/github.com/onflow/flow-core-contracts/lib/go/templates 1.10.4 UnknownUnknown

Scanned Files

  • go.mod
  • insecure/go.mod
  • integration/go.mod

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 731bd7a7-91b4-4c68-aa48-0baf1a118ded

📥 Commits

Reviewing files that changed from the base of the PR and between 73f2c26 and 2799d60.

⛔ Files ignored due to path filters (3)
  • go.sum is excluded by !**/*.sum
  • insecure/go.sum is excluded by !**/*.sum
  • integration/go.sum is excluded by !**/*.sum
📒 Files selected for processing (6)
  • engine/execution/computation/execution_verification_test.go
  • engine/execution/state/bootstrap/bootstrap_test.go
  • go.mod
  • insecure/go.mod
  • integration/go.mod
  • utils/unittest/execution_state.go

📝 Walkthrough

Walkthrough

The pull request upgrades flow-core-contracts from v1.10.3 to v1.10.4 across Go modules and updates genesis commitments, bootstrap test expectations, and a storage-limit test value.

Changes

Contracts and state expectation updates

Layer / File(s) Summary
Flow core contracts dependency versions
go.mod, insecure/go.mod, integration/go.mod
Updates the contracts and templates dependencies to v1.10.4.
Derived execution and bootstrap expectations
utils/unittest/execution_state.go, engine/execution/state/bootstrap/bootstrap_test.go, engine/execution/computation/execution_verification_test.go
Updates genesis and bootstrap commitment values, plus the minimum storage reservation used by the failed-storage-limit test.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • onflow/flow-go#8570: Updates flow-core-contracts dependencies and related genesis and bootstrap commitments.
  • onflow/flow-go#8415: Updates flow-core-contracts dependencies and corresponding state commitment expectations.
  • onflow/flow-go#6877: Updates the same bootstrap and genesis commitment files after execution behavior changes.

Suggested labels: dependencies

Suggested reviewers: zhangchiqing, peterargue

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: upgrading flow-core-contracts to v1.10.4.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch janez/upgrade-core-contracts-v1.10.4

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@janezpodhostnik janezpodhostnik self-assigned this Jul 31, 2026
@codecov-commenter

codecov-commenter commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
utils/unittest/execution_state.go 0.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants