Skip to content

feat: disable Push Alert in dev mode#2429

Merged
zhouxl merged 2 commits into
devfrom
312/disable-note-alert-in-dev
Feb 25, 2026
Merged

feat: disable Push Alert in dev mode#2429
zhouxl merged 2 commits into
devfrom
312/disable-note-alert-in-dev

Conversation

@zhouxl

@zhouxl zhouxl commented Feb 25, 2026

Copy link
Copy Markdown
Collaborator

Related Issue

Summary of Changes

Need Regression Testing

  • Yes
  • No

Risk Assessment

  • Low
  • Medium
  • High

Additional Notes

Screenshots (if applicable)

@zhouxl zhouxl requested a review from a team as a code owner February 25, 2026 01:09
@github-actions

github-actions Bot commented Feb 25, 2026

Copy link
Copy Markdown

PR Summary

Disabled the push notification alert from appearing when the app is running in development mode. Additionally, renamed the global variable isDevModel to isDevMode across the codebase for better naming consistency and clarity.

Changes

File Summary
FRW/App/Env/Prod/EnvDefine.swift Renamed the global constant isDevModel to isDevMode for better naming consistency.
FRW/Modules/Profile/DeveloperMode/DeveloperModeView.swift Updated showDEBUGTool property to use the renamed isDevMode constant.
FRW/Modules/Profile/DeveloperMode/KeychainListViewModel.swift Updated radomUpdatePrivateKey method to use the renamed isDevMode constant for the conditional check.
FRW/Modules/Profile/ProfileView.swift Updated the network check condition to use the renamed isDevMode constant when determining whether to show an alert.
FRW/Services/FlowCoin/CadenceManager.swift Updated the flowDappVersion computed property to use the renamed isDevMode constant when appending the "(Dev)" suffix.
FRW/Services/Manager/PushHandler.swift Added a guard statement in showPushAlertIfNeeded() to return early when isDevMode is true, preventing the push notification alert from being shown in development mode.
FRW/Services/Network/GithubEndpoint.swift Updated ftTokenList and EVMTokenList path computations to use the renamed isDevMode constant for selecting "dev" or "default" JSON files.
FRW/Services/Track/EventTrack.swift Updated the environment determination logic to use the renamed isDevMode constant when setting the env to "development".
FRW/UI/Extension/String.swift Updated convertedAvatarString() method to use the renamed isDevMode constant when selecting the appropriate host for avatar URLs.

autogenerated by presubmit.ai

@github-actions

github-actions Bot commented Feb 25, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚨 Pull request needs attention.

Review Summary

Commits Considered (1)
  • fd6d571: feat: disable Push Alert in dev mode
Files Processed (1)
  • FRW/Services/Manager/PushHandler.swift (1 hunk)
Actionable Comments (1)
  • FRW/Services/Manager/PushHandler.swift [63-65]

    typo: "Possible typo in variable name."

Skipped Comments (0)

Comment thread FRW/Services/Manager/PushHandler.swift Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Review Summary

Commits Considered (1)
  • 1a23c72: feat: rename isDevModel to isDevMode
Files Processed (9)
  • FRW/App/Env/Prod/EnvDefine.swift (1 hunk)
  • FRW/Modules/Profile/DeveloperMode/DeveloperModeView.swift (1 hunk)
  • FRW/Modules/Profile/DeveloperMode/KeychainListViewModel.swift (1 hunk)
  • FRW/Modules/Profile/ProfileView.swift (1 hunk)
  • FRW/Services/FlowCoin/CadenceManager.swift (1 hunk)
  • FRW/Services/Manager/PushHandler.swift (1 hunk)
  • FRW/Services/Network/GithubEndpoint.swift (1 hunk)
  • FRW/Services/Track/EventTrack.swift (1 hunk)
  • FRW/UI/Extension/String.swift (1 hunk)
Actionable Comments (0)
Skipped Comments (1)
  • FRW/Modules/Profile/DeveloperMode/KeychainListViewModel.swift [52-54]

    maintainability: "Empty conditional block with no implementation."

@zhouxl zhouxl merged commit c4e6d67 into dev Feb 25, 2026
4 checks passed
@zhouxl zhouxl deleted the 312/disable-note-alert-in-dev branch February 25, 2026 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants