task1_yael

[yael-dangor]

No description provided.

[omrirz]

General comments:

1. please change "asstst" directory to "assets".
2. please create a subdirectory in assets for icons and a subdirectory for images. we don't want a big mess of files.
3. please change file names to a consistent pattern. You now have "components/service_card.tsx" (which is snake case) and "components/contactForm.tsx" (which is camel case). change all of the files to be kebab case e.g. "service-card.tsx", "contact-form.tsx", etc.
4. You deleted the pages/index.tsx which had valuable components and was holding the home page structure, you should bring it back and use it instead of the changes you did to _app.tsx. See my comment about it below.

[omrirz]

this _app.tsx file is a file for all the pages in the app so now we can't create more pages since you hardcoded those components for the entire app.
You should revert this file and use the pages/index.tsx for the homepage.

[omrirz]

Do we need this file?

[omrirz]

Why we have todos here?

[yael-dangor]

I have a server error:
Server Error
Error: GraphQL Error (Code: 401): {"response":{"data":[{"id":"5413bc","type":"api_error","attributes":{"code":"INVALID_AUTHORIZATION_HEADER","details":{}}}],"status":401,"headers":{}},"request":{"query":"\nquery Homepage {\n homepage(locale: heb) {\n title\n description\n getToKnowUsButton\n aboutHeading\n aboutTitle\n aboutUsText\n aboutUsButton\n whatWeDoHeading\n whatWeDoTitle\n whatWeDoCards {\n title\n text\n imagePath\n }\n contactUsHeading\n contactUsTitle\n contactUsText\n }\n \ncommon {\n contactUsLinks {\n text\n linkType\n imagePath\n }\n contactUsFormFirstName\n contactUsFormLastName\n contactUsFormEmail\n contactUsFormPhone\n contactUsFormMessage\n contactUsFormSendButton\n}\n\n}\n"}}
I tried to solve with a lot of options,
if you can help

[omrirz]

@yael-dangor you sure you have all the necessary environment variables like in .env.example?

[yael-dangor]

Do i need a token?

[omrirz]

1. הלינקים לא עובדים

2. התמונות לא מוצגות טוב

3. אייקונים לא מופיעים

4. אין ולידציה על הטופס

5. כפתורי החלפת שפה לא מחליפים שפה.
6. הקישורים בראש העמוד ״אודות המרפאה״ ו- ״צור קשר״ קופצים לסקשן הרלוונטי במקום לגלול אליו.