M3: configurable shortcuts runtime sync and UI hints - #95
Merged
Merged
Conversation
Co-authored-by: onevpaw <onevpaw@onevcat.com>
Co-authored-by: onevtail <onevtail@onevcat.com>
Finish M2 keybinding resolver routing
…corder Implements M3 of the keybinding integration project (issue #84). Features: - New 'Shortcuts' section in Settings sidebar (SettingsSection.shortcuts) - ShortcutsSettingsView with full keybinding management: - Searchable list of all user-overridable commands grouped by category - Key recording via NSEvent local monitor (supports letters, digits, Return, arrow keys with ⌘⇧⌥⌃ modifiers) - Invalid combination detection (no modifiers, unsupported keys) - Conflict detection using KeybindingConflictPolicy.warnAndPreferUserOverride - Conflict confirmation dialog with Replace / Show Conflict / Cancel - Reset per-command, per-group, or all shortcuts - Source chip showing Default / Migrated / Override status Schema integration: - GlobalSettings gains keybindingUserOverrides field (KeybindingUserOverrideStore) - SettingsFeature.State mirrors keybindingUserOverrides - AppFeature.resolvedKeybindings now computed via resolvedKeybindings() helper that merges global overrides with legacy custom command migrations - settingsChanged delegate propagates keybindingUserOverrides to AppFeature and recomputes resolvedKeybindings immediately Bug fixes: - KeybindingModifiers gains isEmpty property for recorder validation Test coverage: - SettingsFeatureTests.keybindingOverridesPersistAndFanOut - AppFeatureSettingsChangedTests.settingsChangedRecomputesResolvedKeybindings
- fix AppFeature settingsChanged test to assert github integration follow-up actions - add resolver tests for conflict replacement disable semantics and nil-enabled override no-op
Owner
Author
|
Updated for command palette configurability and toolbar hint resolve. Changes:
Verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rename_branch,select_all_canvas_cards)Default/Definedbadge column and shortcut input column with fixed geometryTabfirst, thenPane(instead of mixed alphabetical ordering)Verification
make build-appmise exec -- swiftlint lint --quiet --config .swiftlint.ymlAppShortcutsTestsKeybindingSchemaTestsDetailToolbarTitleTestsUI Acceptance Checklist (Shortcuts Settings)
Setup
Settings -> Shortcuts.Terminal Tabs & Panessection for ordering checks.Checklist
Command,Status, andShortcutcolumns.DefaultandDefinedbadges keep the same visual width and stay column-aligned across rows.Terminal Tabs & Panes, all tab-related actions are listed together before pane-related actions.Previous Tab,Next Tab, thenTab 1 ... Tab 9,Tab 0.Previous Pane,Next Pane,Pane Up,Pane Down,Pane Left,Pane Right.Escduring recording cancels recording without persisting changes.Definedbadge and reset icon are shown; reset works.Reset SectionandReset Allstill behave correctly.Notes