Repository navigation
Register .pwlworkflow as a document package - #845
Merged
Merged
Conversation
Export com.onevcat.prowl.workflow, conforming to com.apple.package, so Finder shows a workflow bundle as one item with a system-generated document icon. The document type has the role None: Prowl has no handler for an opened bundle, so it must not claim to open one.
Owner
Author
|
Review round 1 summary:
|
Owner
Author
|
Review round 2: no new findings. No change after |
Owner
Author
|
Review loop ended at the round cap (4 rounds), not clean. No new findings after round 1 and no change after |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #787.
What
com.onevcat.prowl.workflow(conforms tocom.apple.package, extensionpwlworkflow).CFBundleDocumentTypesentry.CFBundleTypeIconSystemGenerated+UTTypeIconText). Finder composes the page, the Prowl app icon, and the label "WORKFLOW". No icon asset is added, so the icon follows the app icon and the system icon style.Decision: role
NoneProwl has no handler for an opened workflow bundle. The document type has the role
None, so Launch Services does not bind Prowl as the opener. A double-click in Finder reports that no application is set to open the item. WithViewerorEditor, a double-click brings Prowl forward and does nothing.Change the role together with the preview/import entry point when that work is done. A test guards the role.
Audit of Open/Reveal actions
No code change is necessary.
<bundle>/workflow.yaml, not the bundle.activateFileViewerSelecting, which selects the package in Finder.FileManagercalls with no package-aware options.Verification
lsregister -f. A.pwlworkflowdirectory reportsisPackage: true, content typecom.onevcat.prowl.workflow, description "Prowl Workflow", and no default application.QLThumbnailGenerator(.icon): page + Prowl icon + "WORKFLOW".open <bundle>fails withkLSApplicationNotFoundErr; Prowl does not start.prowl workflow validatereads a bundle as before.WorkflowDocumentTypeTests,WorkflowsSettingsFeatureTests,WorkflowSettingsDetailFeatureTests: 23 passed.make checkandmake build-apppass.Not done: the full
make testsuite, and a visual check in a Finder window.Notes
UTTypeIcons, a registered machine can show the old icon until the cache expires.NSWorkspace.icon(forFile:)returns a blank page for this type; Finder and QuickLook show the composed icon.