Repository navigation
Preserve caller parsing and daemon log continuity - #841
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #840, which is stacked on #839. Merge in that order.
The review found two boundary defects: an empty process argument shifted the kernel environment boundary, and a temporary daemon binding failure discarded established log progress.
argcNUL-terminated arguments, preserving empty values before reading the environment. Previously, the first environment entry could be reported as a command argument and omitted from caller identity.Both new regressions failed on the original stack and passed with these changes. The recovery test also checks that a completion written during the gap is delivered and the rollout metadata is not reread.
Validation: 134 related app tests passed;
make check,make build-app,make build-cli,make test-cli-smoke,make test-cli-unit(6 tests), andmake test-cli-integration(105 tests) passed. The original PRs' interactive two-pane acceptance scenarios were not rerun in this review.