Skip to content

Fix OMP Ask prompts reporting as working - #599

Merged
onevcat merged 1 commit into
mainfrom
fix/omp-blocking
Jul 19, 2026
Merged

Fix OMP Ask prompts reporting as working#599
onevcat merged 1 commit into
mainfrom
fix/omp-blocking

Conversation

@onevcat

@onevcat onevcat commented Jul 19, 2026

Copy link
Copy Markdown
Owner

Summary

  • classify Oh My Pi's interactive Ask chooser as blocked before evaluating its spinner
  • add the captured Ask prompt as a screen-heuristic regression test
  • document the Ask chooser blocked-state cue

Verification

  • xcodebuild test … -only-testing:supacodeTests/ScreenHeuristicsTests (25 passed)
  • make build-app
  • make check
  • isolated debug app: repo-built prowl agents --json reported blocked / blocked while a real OMP Ask chooser was visible

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts Oh My Pi/Pi screen heuristics so an interactive Ask chooser is classified as blocked (even if a spinner/status line is present), adds a regression test for that captured prompt, and documents the new blocked-state cue.

Changes:

  • Prioritize detection of Pi/Oh My Pi “Ask” chooser prompts as .blocked before spinner/working-line checks.
  • Add a screen-heuristics regression test fixture for an Ask chooser capture.
  • Update agent-detection docs to mention the Ask chooser as a blocked-state signal.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
supacodeTests/ScreenHeuristicsTests.swift Adds a regression test ensuring an Oh My Pi “Ask” chooser is classified as .blocked.
supacode/Infrastructure/AgentDetection/ScreenHeuristics.swift Updates Pi detection to detect Ask prompts as blocked before evaluating working/spinner cues.
docs/components/agent-detection.md Documents the Ask chooser as a blocked-state cue in screen heuristics.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@onevcat
onevcat merged commit abc94ac into main Jul 19, 2026
2 of 3 checks passed
@onevcat
onevcat deleted the fix/omp-blocking branch July 19, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants