Fix OMP Ask prompts reporting as working - #599
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts Oh My Pi/Pi screen heuristics so an interactive Ask chooser is classified as blocked (even if a spinner/status line is present), adds a regression test for that captured prompt, and documents the new blocked-state cue.
Changes:
- Prioritize detection of Pi/Oh My Pi “Ask” chooser prompts as
.blockedbefore spinner/working-line checks. - Add a screen-heuristics regression test fixture for an Ask chooser capture.
- Update agent-detection docs to mention the Ask chooser as a blocked-state signal.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| supacodeTests/ScreenHeuristicsTests.swift | Adds a regression test ensuring an Oh My Pi “Ask” chooser is classified as .blocked. |
| supacode/Infrastructure/AgentDetection/ScreenHeuristics.swift | Updates Pi detection to detect Ask prompts as blocked before evaluating working/spinner cues. |
| docs/components/agent-detection.md | Documents the Ask chooser as a blocked-state cue in screen heuristics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
xcodebuild test … -only-testing:supacodeTests/ScreenHeuristicsTests(25 passed)make build-appmake checkprowl agents --jsonreportedblocked/blockedwhile a real OMP Ask chooser was visible