Stabilize toolbar status layout - #584
Closed
onevtail wants to merge 2 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request stabilizes the .principal toolbar status area by giving ToolbarStatusView a bounded, compressible layout slot and enforcing single-line tail truncation, eliminating layout shifts when the status content changes (idle hint ↔ PR summary ↔ toast).
Changes:
- Make
ToolbarStatusViewown a fixed ideal/max width (280pt) with single-line tail truncation, and preserve full toast text via hover help + accessibility labels. - Remove duplicated outer horizontal padding from
WorktreeDetailViewcall sites now thatToolbarStatusViewapplies it consistently. - Add regression tests to lock in stable ideal width and single-line behavior under constrained width, plus update the user manual/docs sync metadata.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| supacodeTests/ToolbarStatusViewTests.swift | Adds regression coverage for stable fitting width and single-line truncation under constraint. |
| supacode/Features/Repositories/Views/WorktreeDetailView.swift | Removes duplicated horizontal padding around the principal status item. |
| supacode/Features/Repositories/Views/ToolbarStatusView.swift | Introduces bounded width + truncation and adds tooltip/accessibility text for toast messages. |
| supacode/Features/Repositories/Views/PullRequestStatusButton.swift | Ensures PR/check summary text tail-truncates within the constrained status slot. |
| docs/components/custom-actions.md | Documents the existing “first three commands inline, rest in overflow” behavior. |
| docs/components/canvas.md | Documents the bounded/compressible status area and truncation/hover behavior. |
| docs/.sync-meta.json | Updates docs sync baseline commit/date and note to reflect the manual verification. |
| docs-ai/README.md | Adds entry for the 046 toolbar status layout stability record. |
| docs-ai/046-toolbar-status-layout-stability/000-plan.md | Records the plan/constraints and chosen approach for the status slot stabilization. |
| docs-ai/046-toolbar-status-layout-stability/001-action.md | Records the implementation/verification log for the change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Closed
Owner
|
暂时保留现状。参看 #471 评论 |
onevcat
deleted the
relay/fix-54-optimize-toolbar-layout-jitter-and-statu
branch
August 18, 2026 14:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
The principal status view previously used its intrinsic content width, causing toolbar remeasurement and visible layout shifts when switching between idle hints, PR summaries, and toasts.
Fixes #471
How tested
make checkmake build-appToolbarStatusViewTests(2 passing tests)make test(1,788 passing; one unrelated localExternalDiffToolTestsfailure is blocked by a host Git identity hook)— PR prepared by onevclaw on behalf of @onevcat