chore(talos): remove HPAScaleToZero feature gate - #11602
Open
onedr0p wants to merge 1 commit into
Open
Conversation
HPAScaleToZero graduated to Beta and is enabled by default in Kubernetes 1.37, so the explicit gate on kube-apiserver and kube-controller-manager is redundant. The 15 HPAs with minReplicas: 0 keep scaling to zero. Signed-off-by: Devin Buhl <devin@buhl.casa>
Contributor
|
Note No rendered changes. konflate 0.6.3 · rendered |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
feature-gates: HPAScaleToZero=truefrom theKubeAPIServerConfigandKubeControllerManagerConfigdocuments intalos/controlplane.yaml.j2.HPAScaleToZerograduated to Beta and is enabled by default in Kubernetes 1.37 (pkg/features/kube_features.goat thev1.37.0tag), which the cluster moved to in #11598. The explicit gate no longer does anything. The 15 HPAs withminReplicas: 0continue to scale to zero.Verification
k8s-0withtalosctl machineconfig patch; the result contains noHPAScaleToZeroand the twoextraArgsblocks are otherwise unchanged (enable-aggregator-routingandbind-addressremain).talosctl validate -m metalpasses apart from the placeholder secret used in place of the 1Password reference.Rollout
Nothing applies automatically. After merge,
just talos apply-node <node>on each control-plane node; Talos restarts kube-apiserver and kube-controller-manager on that node, no reboot or drain. A--dry-runfirst should show only the two dropped args.