Added fix for crash observed on listener update while draining old listener's place-holder filter-chain - #3
Open
anirudha-oc wants to merge 1 commit into
Conversation
…stener's place-holder filter-chain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we push a listener configuration containing an on-demand filter chain, a placeholder is created for that. Thus, no FilterChainFactoryContext is created (factory_context_ == nullptr). This factory_context_ is used by filter chain draining logic to trigger the filter chain draining process.
If we again push a new listener config with changes in the on-demand filter chain, this will drain the previous placeholder. It will use factory_context_ to trigger the draining process. But since factory_context_ is null, calling startDraining() function using factory_context_ caused a segfault (crash).
These changes fix that crash.