Restore request options when retrying after token refresh#365
Open
patricknomad wants to merge 1 commit into
Open
Restore request options when retrying after token refresh#365patricknomad wants to merge 1 commit into
patricknomad wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a request returns a
401, theClient::request()callsrefresh()and retries.For some auth methods the
authenticate()re-fetches the version and resource listings via nestedrequest()calls. Those nested calls overwrite the shared$this->options.The catch block restored
$this->urlbut not$this->options:In our situation, this turned a composite
POSTinto aGET /services/data/vXX.0/composite, which returns the composite resource directory rather than acompositeResponse.Fix
Restore the original url and options before the retry:
The assignment is unconditional: it fixes the re-authenticating methods and is a harmless no-op for the others.
Tests
ClientTest: an auth-agnostic contract test at theClient::requestlevel, using a fixture whoserefresh()clobbers$this->optionsvia a nested request.AuthenticationTest: an end-to-end test of anOAuthJWTrefresh path (initial POST, 401, token, versions, resources, retry).