fix(graphql): guard the 401 sign-out path in graphqlFetch - #211
Merged
Conversation
The catch block did `error.response.status === 401 -> window.location.href = "/"` without checking `error.response` exists and without a clean sign-out. Align on the herald/vortex pattern: guard the response, sign out on a genuine 401 OR an UNAUTHENTICATED error code, clear the session server-side, then redirect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns graphqlFetch's error handling on the herald/vortex reference: guards
error.response(network errors are not ClientErrors and must not trigger a redirect / TypeError), signs out on a genuine 401 ORUNAUTHENTICATEDcode, and clears the session server-side before redirecting (was a barewindow.location.href='/'on any 401). Part of the omni eager-logout sweep. tsc/biome clean.