Skip to content

fix(auth): return HTTP 401 for invalid login credentials #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
omkarhole merged 1 commit into from
Jun 3, 2026
Merged

fix(auth): return HTTP 401 for invalid login credentials #282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions backend/controllers/auth.controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ async function login(req, res, next) {
const { email, password } = req.body;
const user = await User.findOne({ email });
if (!user) {
return res.json({ loginStatus: false, Error: 'Invalid Credentials' });
return res.status(401).json({ loginStatus: false, Error: 'Invalid Credentials' });
}
const match = await bycrypt.compare(password, user.password);
if (!match) {
return res.json({ loginStatus: false, Error: 'Invalid Credentials' });
return res.status(401).json({ loginStatus: false, Error: 'Invalid Credentials' });
}
const token = jwt.sign({ id: user._id, email: user.email }, process.env.JWT_SECRET, { expiresIn: '1d' });
res.cookie('token', token, cookieOptions);
Expand Down
Loading