Repository navigation
fix(clippy): remove redundant borrows flagged by CI lint - #5
Closed
NickmDrummer wants to merge 1 commit into
Closed
NickmDrummer wants to merge 1 commit into
NickmDrummer wants to merge 1 commit into
Conversation
Fixes useless_borrows_in_formatting warnings flagged by cargo clippy -- -D warnings (CI lint job).
Owner
|
oh i just fixed it too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The CI lint job (
cargo clippy --all-targets --all-features -- -D warnings) fails on currentmainwith 3xuseless_borrows_in_formattingerrors inbuild_instruction_hover_info(src/lang.rs). This is pre-existing code flagged by newer clippy versions, unrelated to #4.Changes
src/lang.rs: drop redundant&in 3format!args.Verified
cargo fmt --all -- --checkpasses.cargo clippy --all-targets --all-features -- -D warningspasses.cargo test: 17 passed, 0 failed.