Changes from upstream repositories: openmicroscopy

[snoopycrimecop]

• This PR contains changes from upstream repositories

Auto-generated by create-pull-request

[sbesson]

The latest auto-generated commit now includes some of the changes I was expecting to propagate especially in terms of OMERO.web configuration properties following the 5.30.0 release.
Incidentally, it also reverts some of the changes made in #2504. Does this suggest https://github.com/ome/omero-install is out of date with the current content? @pwalczysko @dominikl how do you want to proceed here?

[jburel]

The comment #2504 (comment) explained the situation. This was not taken into account.
Changes must be made in omero-install to be propagated to the doc.
the same applies for omero-web-install

[dominikl]

The changes for omero server install were made in omero-install: ome/omero-install#299 .
The problem here is the omero-web install doc. This is not part of omero-install repo, is it?

[jburel]

https://github.com/ome/omeroweb-install

[dominikl]

Thanks. I was looking for omero-web-install :-/ .

[pwalczysko]

Yes, thank you @sbesson @jburel @dominikl - I had a look at the commit here and it seems that only omero-web changes are being reverted. Do you want to open a PR against omeroweb-install @dominikl ? Or I can do it on Monday ?

[dominikl]

Trying to figure out how I'd get the changes into omeroweb-install, seems to be an assortment of ansible template stuff...

[pwalczysko]

https://github.com/ome/omeroweb-install/blob/master/ansible/templates/rockylinux9/deps.sh.j2 seems to be one which we changed. Also the other .sh.j2 files in the same dir.

[pwalczysko]

The latest auto-generated commit now includes some of the changes I was expected to propagate

@sbesson Do you please have a PR against... some repo... where these changes were initiated ? I cannot see any PR of yours recently on https://github.com/ome/omeroweb-install/pulls - how did the changes here (== the intended changes which you highlight as part of the 5.30.0 release) initiated please ?

[pwalczysko]

Please see ome/omeroweb-install#101 - but the build fails because of lack of maintenance of the stack. I am not sure we should continue with this approach - (autogen of the omero-web-install doc from ansible). Hence my question #2500 (comment)

[sbesson]

@sbesson Do you please have a PR against... some repo... where these changes were initiated ? I cannot see any PR of yours recently on https://github.com/ome/omeroweb-install/pulls - how did the changes here (== the intended changes which you highlight as part of the 5.30.0 release) initiated please ?

The changes I was aiming to bring up to date in documentation were all but about the installation. Part of the logic of the generation script extracts information from the latest release of OMERO.server, OMERO.py and OMERO.web to generate the Configuration properties page amongst others.

[pwalczysko]

@sbesson thank you. In the meantime, I think we have the build on omeroweb-install green and the PR is ready ome/omeroweb-install#102.

[pwalczysko]

@sbesson Please note that ome/omeroweb-install#102 is merged now successfully. Do we need to do something more to propagate the changes in ome/omeroweb-install#102 into omero-documentation ? (such as encourage snoopy to create a PR like the present one, or Tag the omeroweb-install ?)

Edit: I do not believe Tagging of omeroweb-install is necessary, judging by the ome/omero-install#299 tags.

Edit2: according to my reading of

omero-documentation/.github/workflows/update.yml

Line 5 in d883e20

- cron: '* 0 * * *'

the change and PR should be created automatically at the next midnight ?

[pwalczysko]

@sbesson Are you happy with the changes as proposed by this PR ? For the omeroweb-install part I am happy. Should we merge it ?

[sbesson]

Yes definitely happy with the state of the changes from a configuration perspective, thanks