feat: download scenes - #648
Open
jo-mueller wants to merge 6 commits into
Open
Conversation
Merged
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #648 +/- ##
==========================================
+ Coverage 87.09% 87.15% +0.06%
==========================================
Files 17 17
Lines 2518 2531 +13
==========================================
+ Hits 2193 2206 +13
Misses 325 325 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #507
Small PR that injects the
from_ome_zarrandto_ome_zarrio pathway in thedownloadutility function. This will probably be a good way to go for handling the download of other kinds of ome-zarrs as well.I added the download function to the tests that are already in the scene tests, but in the long-term it will probably be good to have a suite of test data somewhere so we don't need to generate dummy data over and over again in the tests here.
Merging this could constitute another patch release?