Skip to content

Preserve metadata on write - #628

Open
jo-mueller wants to merge 10 commits into
ome:masterfrom
jo-mueller:preserve-metadata-on-write
Open

Preserve metadata on write#628
jo-mueller wants to merge 10 commits into
ome:masterfrom
jo-mueller:preserve-metadata-on-write

Conversation

@jo-mueller

@jo-mueller jo-mueller commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Built on top of #623 . In a future (and actually already present) ome-zarr-verse, a zarr group can be both a Scene and a plate, i.e., both keys could be present. This PR makes sure that when we are writing to a zarr group in overwrite=False aka append mode, we are not deleting metadata that may have already been there under the ome key.

✅ Added a test to make sure it works

@jo-mueller jo-mueller added the enhancement New feature or request label Aug 24, 2026
@codecov

codecov Bot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.02%. Comparing base (025e83d) to head (db088d9).

Files with missing lines Patch % Lines
ome_zarr/classes/scene.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #628      +/-   ##
==========================================
+ Coverage   86.91%   87.02%   +0.10%     
==========================================
  Files          17       17              
  Lines        2568     2543      -25     
==========================================
- Hits         2232     2213      -19     
+ Misses        336      330       -6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jo-mueller

Copy link
Copy Markdown
Collaborator Author

Decision: We will defer this to later until it becomes an actual issue. Right now, nuking the metadata is usually fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant