feat: pull schema from ngff page's dev branch - #85
Conversation
✅ Deploy Preview for ome-ngff-validator ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
It worked previously because the schema at e.g. https://raw.githubusercontent.com/ome/ngff-spec/refs/heads/main/schemas/image.schema had Now it has this: (which is why validation is failing) |
|
Both these builds have the same issue: Since the schema at https://ngff.openmicroscopy.org/dev/schemas/image.schema But this PR sets something different: so that the validation library can't find any schema named NB: it's really annoying that when I go to https://ngff.openmicroscopy.org/dev/schemas/image.schema in my browser, I am forced to download the schema instead of viewing it in the browser |
This behavior can probably be changed somehow 🤔 An alternative (probably longer-lasting) fix is here: ome/ngff#564 This will expose the schemas under both which makes sense, I think. I'm not sure why this worked before for 0.6.devX and doesn't work anymore for |
|
It worked before because the schemas contain e.g. This corresponds to the id that we set in JavaScript: NOW, the schemas have but this is DOESN'T match the JavaScript: The problem is that the JavaScript doesn't know how the schemas are referenced within the schema, so we have to hard-code it. |
|
@jo-mueller from what we discussed on the PR review, the current plan would be using the tags on ngff-spec directly, right? Also discussed on: |
|
+, using |
This PR changes the location from which to pull the schemas to the
devsubpage of the ngff page, see also ome/ngff#563. I'm not entirely sure why this previously worked with0.6.dev4hardcoded into the URL, though 🤔