fix(backend): guard vehicle deletion and align error code field acros…#6
Merged
Conversation
…s clients - Block DELETE /vehicles/:id while the vehicle is online or assigned; throws VehicleStillAssignedError (VEHICLE_STILL_ASSIGNED) or VehicleOnlineError (VEHICLE_ONLINE) — both map to 409 via the existing DomainExceptionFilter, keeping the error envelope consistent. - Add Swagger conflict examples on the DELETE endpoint. - Fix admin-dashboard ApiErrorBody.code → error (field mismatch with the filter's response shape; operator-dashboard was already correct). - Remove broken boilerplate e2e test (tested GET / → 'Hello World!' which never existed in this app). - Document concurrency-test sequential-execution limitation in README. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
maaref-insat
approved these changes
Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s clients
Summary
Changes
Testing
npm testinapps/backendpassesnpx tsc --noEmitpasses in both apps/docsNotes for reviewers