fix(backend): align domain error response envelope with Nest default …#3
Merged
Conversation
…shape
DomainExceptionFilter previously emitted { statusCode, code, message }
while Nest's built-in HttpException emits { statusCode, message, error }.
The two shapes coexisting across the same API surface meant clients had
to branch on which endpoint they hit to know which field to read.
Rename the filter's output field from 'code' to 'error' so every JSON
error body has the same key layout regardless of whether it originated
in the domain filter (fleet-management rule violations) or in a Nest
exception (vehicle CRUD 404s, ValidationPipe failures, ...). The stored
value is unchanged — it still carries the machine-readable domain code
like VEHICLE_ALREADY_ASSIGNED.
Swagger examples in vehicles / operators / fleet-management openapi.ts
updated to reflect the new key.
Operator dashboard is updated in the same commit — its api.ts parses
body.error into ApiError.code, and the ApiErrorBody type renames the
wire field. Internal ApiError.code stays as-is to avoid touching every
call site.
maaref-insat
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…shape
DomainExceptionFilter previously emitted { statusCode, code, message } while Nest's built-in HttpException emits { statusCode, message, error }. The two shapes coexisting across the same API surface meant clients had to branch on which endpoint they hit to know which field to read.
Rename the filter's output field from 'code' to 'error' so every JSON error body has the same key layout regardless of whether it originated in the domain filter (fleet-management rule violations) or in a Nest exception (vehicle CRUD 404s, ValidationPipe failures, ...). The stored value is unchanged — it still carries the machine-readable domain code like VEHICLE_ALREADY_ASSIGNED.
Swagger examples in vehicles / operators / fleet-management openapi.ts updated to reflect the new key.
Operator dashboard is updated in the same commit — its api.ts parses body.error into ApiError.code, and the ApiErrorBody type renames the wire field. Internal ApiError.code stays as-is to avoid touching every call site.
Summary
Changes
Testing
npm testinapps/backendpassesnpx tsc --noEmitpasses in both apps/docsNotes for reviewers