Require typed confirmation before resetting the VM - #96
Open
jamesyork-prog wants to merge 2 commits into
Open
Conversation
Reset permanently erases the VM. Keep the destructive action disabled until the user types the exact application name, and present the confirmation as a cancellable native sheet.
Document the exact confirmation phrase and make clear that cancelling or dismissing the sheet leaves VM storage unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Try Omarchybefore enabling the destructive Reset actionWhy
Reset permanently removes the virtual machine, including its apps, files, accounts, and settings. A typed confirmation adds useful friction and makes accidental activation much less likely.
Tests
make test