Fix GTK icon cache generation - #105
Open
Fail-Safe wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Omarchy 4.0.2 includes display-style artwork names such as
Google Messages.png,Disk Usage.png, andRetro Gaming.png. Try Omarchy copied those basenames verbatim into/usr/share/icons/hicolor/256x256/apps, while the desktop entries referencegoogle-messages,disk-usage, andretro-gaming.Besides preventing those icon lookups from matching, the embedded spaces make
gtk-update-icon-cachereject the generated cache. This surfaces duringomarchy-updateas:The materializer now performs the same ASCII lowercase-and-hyphen normalization already reflected in the desktop icon identifiers.
Validation
gtk-update-icon-cache -f -t /usr/share/icons/hicolorreportedCache file created successfully, with no remaining cache-unsafe pathsguest/test --source <clean pinned Omarchy 4.0.2 checkout>: 64 tests plus all guest/materialization contracts passmake test: build-cache tests, guest tests, macOS compatibility and relocation checks, 181 Swift tests across 42 suites, and QEMU networking/power/storage suites passgit diff --check, shell syntax, and Python compilation passmake buildwas also attempted, but the guest build stops before materialization because the current Arch Linux ARM repository transaction has advanced beyondpackages.lock.json. This PR deliberately does not mix an unrelated 24-package lock refresh into the icon fix.