Fall back to QFile when QSaveFile fails on CIFS/SMB - #50
Open
rva79 wants to merge 1 commit into
Open
Conversation
QSaveFile uses Linux O_TMPFILE. CIFS returns ENOENT instead of EOPNOTSUPP, so Qt never falls back to a named temp file and save fails even though the share is writable. Write the destination directly in that case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Saving to a CIFS/SMB mount fails in Omawrite with Could not save …, even when the share is mounted read-write and a normal file write succeeds.
Backend::saveTousesQSaveFile. On Linux that creates an unnamed temp file withO_TMPFILE, then materializes it withlinkat. CIFS does not supportO_TMPFILEand returnsENOENTrather thanEOPNOTSUPP. Qt only treatsEOPNOTSUPPandEISDIRas “not supported”, so it never falls back to a named temp file andQSaveFile::open()fails.QSaveFile::setDirectWriteFallback(true)does not help: that path only retries onEACCES.Reproduced with Qt 6.11:
open(dir, O_TMPFILE | O_RDWR)on CIFS →ENOENTmkstemp/QFileon the same directory → successQSaveFile::openon the same directory →"No such file or directory"Change
Keep
QSaveFileas the default (atomic replace on local filesystems). If that fails, write the destination withQFileso saves still work on CIFS/SMB.Recovery snapshots stay on
QSaveFile; those go toAppDataLocationon a local disk.Test plan
./bin/test(12 passed)Ctrl+Shift+S)Ctrl+S)