Bound lock authentication resource use - #10082
Draft
vip32 wants to merge 1 commit into
Draft
Conversation
Author
|
Work on existing draft PR #10082 and issue #10078. Check out fix/10078-lock-auth-resource-bounds, read AGENTS.md, agents/skills/shell-dev.md, and agents/skills/visual-verification.md. Review the PR’s analysis, choose and document sensible resource limits, implement the focused fix with regression tests, run ./test/shell and ./test/all, perform relevant live lock-screen verification, then commit and push to the existing branch. Do not create another PR or mark the current PR ready yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The lock/authentication surface currently relies on limits and lifecycle behavior that are too permissive for a long-running security-sensitive UI:
TextMetricsstring, retained aspendingPassword, and forwarded to PAM.fprintd-listcapability probe have no explicit deadline or recovery path when PAM or fprintd stalls.completed(PamResult.Error)aftererror, while the current handlers perform failure transitions from both callbacks.Planned changes
TextInputboundary so typed and pasted input is bounded before masking and layout work.pendingPasswordor responding to PAM.Testing plan
./test/shelland./test/all.Status
Draft: analysis is complete; implementation and Omarchy runtime verification are pending.
Fixes #10078