Release the panel cursor when the pointer leaves a row - #10077
Open
ludagoo wants to merge 2 commits into
Open
Conversation
CursorSurface promised one highlight driven by mouse and keyboard, but leave never cleared it: Button used an overlay HoverHandler, and every panel claimed the cursor on enter only. Pointer enter still claims; leave now releases, including a keyboard selection. First-party panels go through Cursor.applyHover. Third-party plugins that use the kit still need the same leave call.
A relative import of Cursor.js broke fixtures that copy a panel out of tree, and CursorSurface.hovered collided with Tailscale's copy-menu signal. Export a Cursor singleton from qs.Ui and drop the copy-menu duplicate.
Contributor
Author
|
Human here. I know this touches a lot of things, but it’s an improvement for mouse UI, and I don’t think it hurts keyboard navigation at all. It felt weird that moving the pointer off a button didn’t unselect it. Now it does. I understand the idea of handing off from mouse to keyboard, but who actually switches from mouse to keyboard like that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Panel rows share one cursor (
hasCursor/currentonCursorSurface). Mouse enter moved that cursor; leave did not, so a hover (or a previous arrow-key selection) stayed painted after the pointer moved off the row.This updates the kit contract:
ButtonemitshoveredfromcontainsMouseso leave actually fires under the panel overlay.Cursor.applyHoveris the shared enter/leave policy.Third-party plugins that bind
hasCursorthemselves still need to callCursor.applyHoveron leave; the kit cannot set theircursorActivefor them.Test plan
bash test/shell.d/cursor-contract-test.shSeparate from the battery-percentage PR.