Dedupe sound menu output and input entries - #10071
Open
fresh3nough wants to merge 1 commit into
Open
Conversation
Collapse nodes that share a node.name or friendly label so output and input rows no longer list the same hardware twice. Also drop sink monitor capture nodes from the input candidate list. Fixes omacom#9887 Signed-off-by: fresh3nough <anonwurcod@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node.nameor the same friendly device label before the sound menu Repeaters render, so one physical device no longer appears twice.test/shell.d/audio-dedup-test.shcovering Model dedupe behavior and the Panel contract thatrawAudioSinks/rawAudioSourcesreturn throughdedupeAudioNodes.Fixes #9887
Test plan
bash test/shell.d/audio-dedup-test.shbash test/shell.d/audio-test.sh