Clear set-ID bits on Windows VM directories - #10046
Open
0bsolescence wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9374.\n\nGNU chmod preserves set-ID bits on directories when applying a numeric mode, so a shared directory left at mode 2700 remained 2700 after chmod 0700. The following exact-mode check then rejected it and prevented the Windows VM from launching.\n\nUse an explicit symbolic mode that clears special bits while setting private 0700 permissions. Add a mount-boundary regression case starting with a setgid shared directory.\n\nTests:\n- bash test/shell.d/windows-vm-mount-boundary-test.sh (passes in an isolated privileged namespace)\n- ./test/all (Windows VM tests pass; five unrelated environment-dependent files fail because omarchy-pkgs is not checked out and the live desktop differs from test expectations)