Fix Flea tests in constrained builders - #290
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The RC builder has Bubblewrap installed, but its nested container cannot create an unprivileged namespace. Flea's tests treated "installed" as "usable", so eight sandbox integration tests failed before the package could build. Two thumbnailer fixture tests also assumed optional host thumbnailers that are not part of the build environment.
This keeps Flea's runtime sandbox unchanged. The package still fails closed when Bubblewrap cannot start.
check()now probes the same constrained Bubblewrap invocation Flea uses and skips only those eight integration tests when namespaces are unavailable. It also skips only the two host-thumbnailer fixtures when their optional programs are missing. The remaining Rust, QML, and keymap checks still run.Validated in both environments:
flea 0.1.2-2packages successfully.The
pkgrelbump ensures the corrected build recipe produces a new immutable artifact.