[codex] Revoke passwordless grants when settings is removed - #257
Open
AFOliveira wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on
This is an 8-line follow-up to #239 and should merge after it. It deliberately
reuses that maintainer-owned package-ownership work instead of copying it.
Companion source PR: omacom/omarchy#9457
Problem
The settings package owns the boot-time tmpfiles rule that removes stale
Omarchy passwordless-sudo grants. Removing the package removes that safety net;
without synchronous cleanup, an already-live sudoers rule could then survive
until an unrelated path removes it.
Fix
Both stable and development settings scriptlets remove only the namespace that
Omarchy's tmpfiles rule already owns:
/etc/sudoers.d/99-omarchy-nopasswd-*This runs in
post_remove, in the same package transaction that removes theboot cleanup. Unrelated sudoers policy is untouched.
Validation
bash -n.git diff --checkpasses.post_removefunctionsagainst disposable roots and confirms that generated grants are removed,
unrelated policy remains, and Package Omarchy static system state #239's
/etc/os-releaseownership behavior ispreserved.