This repository was archived by the owner on Sep 14, 2025. It is now read-only.
Fix shell expansion on wifi password#17
Open
fabricioanciaes wants to merge 3 commits into
Open
Conversation
fabricioanciaes
marked this pull request as ready for review
August 30, 2025 06:59
fabricioanciaes
force-pushed
the
master
branch
from
August 30, 2025 07:15
0e8fc09 to
8ebce6d
Compare
fabricioanciaes
marked this pull request as draft
August 30, 2025 07:17
adds a gum prompt and passes the password via iwctl's --passphrase
fabricioanciaes
force-pushed
the
master
branch
from
August 30, 2025 07:18
8ebce6d to
680b061
Compare
fabricioanciaes
marked this pull request as ready for review
August 30, 2025 07:21
Contributor
|
Think we need to detect if the ssid needs a password so we're not asking on open networks. |
Author
Now it connects to open networks without prompting for passwords, only prompts for password on secured wifi connections. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passwords with $ weren't working due to shell expansion, not only that, they were completely crashing the installation on my end and with no feedback.
Simple example of shell expansion in action:
Added a
gumprompt for password before passing the actual password toiwctlvia--passphraseparameterAlso need help testing this properly as I'm having trouble recreating this on baremetal.