Non-empty versions of Itertools::chunk_by#41
Open
ronnodas wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
Is it better to name the methods |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The groups yielded by
Itertools::chunk_byare always non-empty. Further, if the input iterator is non-empty, then it yields at least one group.Since the
ChunkByonly implementsIntoIterator, I used two wrapper structs to pass through the indirections. For similar reasons,Iterator1::chunk_by1()returnsNonEmpty<ChunkBy>.Are there default methods
Groups1should implement? Should the construction of theNonEmptyinIterator1::chunk_by1()have safety comments?