Python interface for 3PCF#16
Open
misharash wants to merge 120 commits into
Open
Conversation
(except legacy)
This reverts commit 1761cc6.
from a copy of 2PCF
Deleted irrelevant arguments and pieces of code and outlined the new arguments and missing pieces
from 2PCF
from 2PCF
from 2PCF
Seemed unhelpful
from ENCORE to RascalC (internal) convention
It probably would be very rare in practice, but still easier to guarantee the same number of loops in the two integrals
According to previous removal from C++ code
Make ease the normalization issue
Collaborator
Author
|
From semi-accidental tests, it seems like 2PCF covariance convergence gets much worse in the 3PCF dev version. Not yet sure why/how exactly that can be. But if this is tracked down, it may help with the 3PCF covariance convergence issues too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds library functions to run and post-process 3PCF covariance matrices from Philcox et al 2019, interfaced with the ENCORE estimation framework.
May deserve a major version.
To be done: test that the 2PCF functionality is not affected (it should not be, but it might be). Ideally, also get the 3PCF covariances to converge.