Skip to content

fix(ci): fix clang build failure and DockerHub image ref errors #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
volschin merged 2 commits into from
Mar 28, 2026
Merged

fix(ci): fix clang build failure and DockerHub image ref errors #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cdfc22f
fix(ci): scope -Wno-error=maybe-uninitialized to gcc only in build wo…
claude Mar 28, 2026
801dd75
fix(ci): guard DockerHub image refs against unset DOCKER_USERNAME secret
claude Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,11 @@ jobs:

strategy:
matrix:
cc: [gcc, clang]
include:
- cc: gcc
extra_cflags: -Wno-error=maybe-uninitialized
- cc: clang
extra_cflags: ''

steps:
- name: Checkout repository
Expand All @@ -36,6 +40,6 @@ jobs:
sudo apt-get install -y libusb-1.0-0-dev ${{ matrix.cc }}

- name: Build with ${{ matrix.cc }}
run: make CC=${{ matrix.cc }} CFLAGS="${CFLAGS} -Werror -Wno-error=maybe-uninitialized"
run: make CC=${{ matrix.cc }} CFLAGS="${CFLAGS} -Werror ${{ matrix.extra_cflags }}"
env:
CFLAGS: -MMD -O2 -Wall -Wextra -I/opt/local/include -g
12 changes: 10 additions & 2 deletions .github/workflows/docker-image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
with:
images: |
ghcr.io/${{ github.repository }}
${{ secrets.DOCKER_USERNAME }}/${{ github.event.repository.name }}
${{ secrets.DOCKER_USERNAME != '' && format('{0}/{1}', secrets.DOCKER_USERNAME, github.event.repository.name) || '' }}
tags: |
type=ref,event=branch
type=ref,event=pr
Expand Down Expand Up @@ -103,6 +103,14 @@ jobs:
run: |
images=""
for tag in ${TAGS}; do
images+="${tag}@${DIGEST} "
# Only sign tags for registries that were actually pushed to
case "${tag}" in
ghcr.io/*) images+="${tag}@${DIGEST} " ;;
*/*)
if [ -n "${{ secrets.DOCKER_USERNAME }}" ]; then
images+="${tag}@${DIGEST} "
fi
;;
esac
done
cosign sign --yes ${images}