chore: upgrade dependencies - #156
Open
BenjaminTruong-okta wants to merge 8 commits into
Open
Conversation
…in-replace delimiters regression
Newer node-releases (>=2.0.45, pulled in transitively via browserslist) declares engines.node >=18, which breaks yarn install --frozen-lockfile on CI's pinned Node 16.20.2.
Node 16 is EOL and was requiring a node-releases resolution pin to keep yarn install from failing on newer transitive dependencies.
vue-router@5.2.0 (upgraded this session) depends on @babel/generator@8.0.0, which requires node ^22.18.0 || >=24.11.0. Verified no other installed package's engines.node field is incompatible with 24.19.0.
24.19.0 was released 4 days ago and isn't in the internal nvm mirror yet (exit code 3, version not found). 24.11.0 is the earliest 24.x release satisfying @babel/generator's >=24.11.0 requirement and has had ~9 months to propagate.
Pre-existing dead import (since 5335310) was only a warning locally, but CI's lint step fails on it.
@wdio/selenium-standalone-service resolved to a newer 7.x patch that requires selenium-standalone ^9.0.3, which only fetches chromedriver from the Chrome for Testing bucket. That bucket doesn't host anything for Chrome 106 (pinned in scripts/e2e.sh), causing a 404. 8.2.1 restores the legacy chromedriver source that supports old Chrome versions.
Node 24's bundled npm requires an explicit --tag for prerelease-looking versions (ci-append-sha produces e.g. 5.10.0-<sha>), unlike the npm 8.x bundled with Node 16 which defaulted to 'latest'. This restores that prior default explicitly.
| * See the License for the specific language governing permissions and limitations under the License. | ||
| */ | ||
|
|
||
| import { App, shallowRef, triggerRef, version } from 'vue' |
Author
There was a problem hiding this comment.
unused variable, called out by linter
| 'eslint:recommended', | ||
| '@vue/typescript/recommended' | ||
| ], | ||
| rules: { |
Author
There was a problem hiding this comment.
disabling a new ESLint rule that flagged single-word component names
BenjaminTruong-okta
marked this pull request as ready for review
August 10, 2026 04:13
BenjaminTruong-okta
changed the title
| "test:e2e": "yarn workspace @okta/test.e2e-wdio test", | ||
| "test:unit": "jest", | ||
| "bundle": "rollup -c rollup.config.js", | ||
| "bundle": "rollup -c rollup.config.js --bundleConfigAsCjs", |
Contributor
There was a problem hiding this comment.
did rollup stop working without this flag?
Author
There was a problem hiding this comment.
yeah the flag is required by the rollup bump.
otherwise it fails with "require is not defined in ES module scope" (because rollup v4 changed how js config files are loaded, now as native ESM where "require" doesn't exist)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Non-dependency changes
rollup.config.js
ESM (rollup 4.62.4).
PACKAGE/AUTH_JS are only used via property access, so replacement was silently skipped, shipping unresolved identifiers (AUTH_JS
is not defined at runtime).
jest.config.js
dependency; it's ESM-only ("type": "module") and needs Jest to transform it despite being in node_modules.
src/components/LoginCallback.vue
which flags {} as a type.
test/apps/test-harness/.eslintrc.js, test/components/.eslintrc.js
component files (App.vue, Home.vue, Protected.vue).
src/okta-vue.ts
(no-unused-vars).
CI-only changes
dependency requires Node ^22.18.0 or ≥24.11.0. Picked 24.11.0 specifically since the internal nvm mirror lags newest patch
releases.
bump) and selenium-standalone to 8.2.1 (@wdio/selenium-standalone-service resolved to a version requiring selenium-standalone 9.x,
which only fetches chromedriver from a bucket that doesn't host the Chrome 106 build this repo's e2e suite pins).
versions (the SHA-suffixed version ci-append-sha produces); Node 16's older npm defaulted to latest implicitly.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Reviewers