fix: keep the issuer path in the OIDC discovery URL - #111
Open
official-burak wants to merge 1 commit into
Open
Conversation
A leading slash on /.well-known/openid-configuration is origin-relative, so custom authorization servers such as https://{domain}/oauth2/default were discovering from the org root.
Resolves: okta#110
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What is the current behavior?
Issuer.discover(new URL('/.well-known/openid-configuration', issuer))treats that path as origin-relative. A custom authorization server such ashttps://{yourOktaDomain}/oauth2/defaultthen requests/.well-known/openid-configurationon the org root instead of under/oauth2/default.Issue Number: #110
What is the new behavior?
Discovery is built from a trailing-slash issuer base plus a relative
.well-known/openid-configurationsuffix, so the issuer path is kept. Org-level issuers still hit/.well-known/openid-configuration. Unit tests cover both a path issuer and a trailing slash.Does this PR introduce a breaking change?