Skip to content
This repository was archived by the owner on Sep 11, 2025. It is now read-only.

Add lint-graphql job - #55

Draft
ccamel wants to merge 1 commit into
mainfrom
ci/graphql-inspector
Draft

Add lint-graphql job#55
ccamel wants to merge 1 commit into
mainfrom
ci/graphql-inspector

Conversation

@ccamel

@ccamel ccamel commented Aug 25, 2023

Copy link
Copy Markdown
Member

Addresses issue #6 by integrating the actions/graphql-inspector GitHub action into the CI.

screenshot

To be tested in more depth with future PRs that amend the schema.

@ccamel ccamel self-assigned this Aug 25, 2023
@ccamel
ccamel force-pushed the ci/graphql-inspector branch 4 times, most recently from 245e328 to aa792ef Compare August 25, 2023 09:15
@ccamel
ccamel marked this pull request as ready for review August 25, 2023 09:22
@ccamel
ccamel force-pushed the ci/graphql-inspector branch from aa792ef to 6bd251a Compare August 25, 2023 15:22
@ccamel
ccamel force-pushed the ci/graphql-inspector branch from 6bd251a to 71358a5 Compare September 4, 2023 09:51
@ccamel
ccamel force-pushed the ci/graphql-inspector branch from 71358a5 to f9878d8 Compare September 4, 2023 09:52
@ccamel

ccamel commented Sep 4, 2023

Copy link
Copy Markdown
Member Author

No longer works because the evaluated schema is incomplete (e.g. the BigInt scalar is not defined). Another approach must be considered. 馃槶

@ccamel
ccamel marked this pull request as draft September 4, 2023 13:05
@ccamel

ccamel commented Sep 4, 2023

Copy link
Copy Markdown
Member Author

AFIK, it doesn't seem possible to extract the complete GraphQL schema directly from the subql cli. Then, the safest approach would be to do the following: as part of the CI workflow execution, start two instances of SubQL, one on the main branch and another on the PR branch. Then use the actions/graphql-inspector to perform the diff between the two, resolving their respective GraphQL endpoints. A bit cumbersome, but safer, I guess.

FYI @amimart

@ccamel
ccamel force-pushed the main branch 5 times, most recently from d6b456c to 9280ca2 Compare October 30, 2023 12:17
@ccamel
ccamel force-pushed the main branch 2 times, most recently from c55941b to 02b1c31 Compare November 8, 2023 19:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants