Skip to content

add comments on instability issue - #136

Merged
ohno merged 1 commit into
mainfrom
test-polynomials
Aug 5, 2026
Merged

add comments on instability issue#136
ohno merged 1 commit into
mainfrom
test-polynomials

Conversation

@ajarifi

@ajarifi ajarifi commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

This is a pull request related to #101.

Add some notes on numerical stability for several related polynomials.

@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.36%. Comparing base (f0e80dc) to head (f0a6587).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
+ Coverage   87.30%   87.36%   +0.06%     
==========================================
  Files          11       11              
  Lines         378      380       +2     
==========================================
+ Hits          330      332       +2     
  Misses         48       48              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ohno ohno left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pull request related to #101.

I think that comment is generally fine (what we needed). But I'm not sure that Laguerre polynomials, Legendre polynomials, and Hermitian polynomials have been sufficiently tested.

@ajarifi ajarifi closed this Jul 31, 2026
@ajarifi ajarifi reopened this Jul 31, 2026
@ajarifi

ajarifi commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator Author

FYI, when I tested the polynomials again. Related to #97, #143, the generalized Laguerre polynomials still contain $\alpha$, and spherical harmonics also contain $\theta$ and $\phi$.

@ajarifi

ajarifi commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator Author

I wonder if, for HO potential, the Hermite polynomial should replace the Laguerre polynomial.

@ajarifi

ajarifi commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator Author

In #146, I compare the results obtained from the recurrence relation and the closed form. Evidently, they give consistent results for up to $n=10$. Therefore, the results from the closed form are reliable up to $n=10$. Above that number, there are some problems, such as the need for $n=big(number)$, instability, etc. As a future development, the recurrence relation can be used.

@ohno ohno left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sufficient testing has been done at #146.
Close #101
Close #146

@ohno
ohno merged commit bf9605d into main Aug 5, 2026
8 checks passed
@ajarifi
ajarifi deleted the test-polynomials branch August 6, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants